Skip to content

Remove default home value #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
code-asher opened this issue Feb 18, 2021 · 1 comment · Fixed by #2800
Closed

Remove default home value #2742

code-asher opened this issue Feb 18, 2021 · 1 comment · Fixed by #2800
Assignees
@code-asher
Labels
enhancement Some improvement that isn't a feature
Milestone
v3.9.1

Comments

@code-asher
Copy link
Member

code-asher commented Feb 18, 2021 •
edited
Loading

I think if we have no default the home button will not appear unless the user explicitly provides --home which is what we want.
@code-asher code-asher added the enhancement Some improvement that isn't a feature label Feb 18, 2021
@code-asher code-asher changed the title Modify go home behavior in iframes Remove default home value Feb 25, 2021
@jsjoeio jsjoeio added this to the v3.9.2 milestone Feb 25, 2021
code-asher added a commit that referenced this issue Mar 1, 2021
@code-asher
Remove default home value
e6d197d 
Closes #2742.
@code-asher code-asher self-assigned this Mar 1, 2021
@code-asher code-asher modified the milestones: v3.9.2, v3.9.1 Mar 1, 2021
code-asher added a commit that referenced this issue Mar 1, 2021
@code-asher
Remove default home value
f526ab8 
Closes #2742.
@greyscaled greyscaled linked a pull request Mar 2, 2021 that will close this issue
Remove default home #2800
Merged
@greyscaled
Copy link
Contributor

Fixed in 29f3021

@code-asher code-asher mentioned this issue May 3, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging a pull request may close this issue.

Remove default home coder/code-server
3 participants
@jsjoeio @greyscaled @code-asher