Skip to content

docs: clarify Alpine install path in install.md #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2021
Merged

docs: clarify Alpine install path in install.md #2696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f92fd2c
clarify alpine on install docs
bpmct Feb 8, 2021
4318ac6
fix whitespace
bpmct Feb 8, 2021
3dcb92b
fix npm docs link in install.sh
bpmct Feb 8, 2021
e4c82a0
update branch in URLs
bpmct Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ We recommend installing with `yarn` or `npm` when:

1. You aren't on `amd64` or `arm64`.
2. If you're on Linux with glibc < v2.17 or glibcxx < v3.4.18
3. You're running Alpine Linux. See [#1430](https://github.com/cdr/code-server/issues/1430#issuecomment-629883198)

**note:** Installing via `yarn` or `npm` builds native modules on install and so requires C dependencies.
See [./npm.md](./npm.md) for installing these dependencies.
Expand Down
6 changes: 3 additions & 3 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -eu

# code-server's automatic install script.
# See https://github.com/cdr/code-server/blob/master/docs/install.md
# See https://github.com/cdr/code-server/blob/v3.8.1/docs/install.md

usage() {
arg0="$0"
Expand Down Expand Up @@ -67,7 +67,7 @@ Usage:

It will cache all downloaded assets into ~/.cache/code-server

More installation docs are at https://github.com/cdr/code-server/blob/master/docs/install.md
More installation docs are at https://github.com/cdr/code-server/blob/v3.8.1/docs/install.md
EOF
}

Expand Down Expand Up @@ -419,7 +419,7 @@ install_npm() {
echoh
echoerr "Please install npm or yarn to install code-server!"
echoerr "You will need at least node v12 and a few C dependencies."
echoerr "See the docs https://github.com/cdr/code-server#yarn-npm"
echoerr "See the docs https://github.com/cdr/code-server/blob/v3.8.1/docs/install.md#yarn-npm"
exit 1
}

Expand Down