Skip to content

docs: clarify Alpine install path in install.md #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2021

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Feb 8, 2021

From install.md, the path to install code-server on Linux Alpine is unclear.

#1430 recommends using the npm script, since the install script doesn't work.

@bpmct bpmct requested review from nhooyr and removed request for nhooyr February 8, 2021 14:17
@jsjoeio jsjoeio self-requested a review February 8, 2021 18:22
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this, Ben! 🙌

One small change

@bpmct bpmct requested a review from jsjoeio February 9, 2021 12:38
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jsjoeio jsjoeio added this to the v3.8.2 milestone Feb 9, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 10, 2021

@bpmct just realized - can you sign your commits so that they're verified and we can merge this?

If not, happy to pull down, rebase and sign them for you!

@bpmct bpmct force-pushed the clarify-alpine branch 3 times, most recently from 5b0a681 to 134cb8b Compare February 11, 2021 12:55
@bpmct bpmct force-pushed the clarify-alpine branch 2 times, most recently from 78daa29 to e4c82a0 Compare February 11, 2021 13:05
@bpmct
Copy link
Member Author

bpmct commented Feb 11, 2021

@jsjoeio done, sorry about that!

@jsjoeio jsjoeio merged commit 1272bf9 into coder:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants