Fix 404 webviews and tar endpoint #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra slash caused a 404 (was /webview//vscode-resource).
It was checking the request path but for tars the path is in the query variable so the request path is irrelevant.
nhooyr
approved these changes
Nov 19, 2020
| // Used by VS Code to load extensions into the web worker. | ||
| const tar = Array.isArray(req.query.tar) ? req.query.tar[0] : req.query.tar | ||
| if (typeof tar === "string") { | ||
| ensureAuthenticated(req) |
There was a problem hiding this comment.
Def need to mention this bug in release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2329