Skip to content

Git Graph Extension Broken #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asomethings opened this issue Nov 17, 2020 · 12 comments
Closed

Git Graph Extension Broken #2317

asomethings opened this issue Nov 17, 2020 · 12 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@asomethings
Copy link

Steps to reproduce

  1. Install Git Graph from Extensions tab

  2. Reload VSCode

  3. Open Git Graph

  4. Git Graph showes you broken ui with nothing showing

image

Git graph broked right after upgrading to 3.7.1. Tested in Chrome, Firefox.

Log after opening git graph

GET https://url-of-code-server/webview//vscode-resource/file///root/.local/share/code-server/extensions/mhutchie.git-graph-1.27.0/media/out.min.css net::ERR_ABORTED 404 (Not Found)

GET https://url-of-code-server/webview//vscode-resource/file///root/.local/share/code-server/extensions/mhutchie.git-graph-1.27.0/media/out.min.js net::ERR_ABORTED 404 (Not Found)

GET https://url-of-code-server/webview//vscode-resource/file///root/.local/share/code-server/extensions/mhutchie.git-graph-1.27.0/media/out.min.js net::ERR_ABORTED 404 (Not Found)
  • Web Browser: Chrome 86.0.4240.198 / Firefox Nightly 85.0a1
  • Local OS: Windows 10 Pro x64 / macOS Big Sur
  • Remote OS: Ubuntu 16.04
  • Remote Architecture: x86_64
  • code-server --version: 3.7.1 2bf91ff
@asomethings asomethings changed the title Git graph broken Git Graph Extension Broken Nov 17, 2020
@pfitzseb
Copy link

This seems to be a general problem with resolving webview URIs; I'm seeing the same issue with multiple extensions.

@BenjaminBeichler
Copy link

@pfitzseb sorry for capturing this issue, but could this also affect vscode.image-preview ? I cannot view PNG files, which are in the project folders.

@pfitzseb
Copy link

Most likely. Basically every bit of custom UI you can find in VSCode is implemented as a Webview, all of which are broken if they try to load local resources.

@BenjaminBeichler
Copy link

BenjaminBeichler commented Nov 19, 2020

Seems to be that #2336 is going to fix this, isn't it ?

Would be nice to see this published quickly :-D

@code-asher code-asher added this to the v3.7.2 milestone Nov 19, 2020
@code-asher code-asher self-assigned this Nov 19, 2020
@code-asher code-asher added the bug Something isn't working label Nov 19, 2020
@code-asher
Copy link
Member

Fixed, will be in the next release!

@pfitzseb
Copy link

Thanks for the prompt fix!

@catthehacker
Copy link
Contributor

This seems to still be an issue in v3.9.3

@jsjoeio
Copy link
Contributor

jsjoeio commented May 10, 2021

@catthehacker if you're still experiencing issues, please file a bug report and we'll see how we can help!

@lz1998
Copy link

lz1998 commented Jul 15, 2021

This seems to still be an issue in 3.11.0 4e8cd09ef0412dfc7b148b7639a692e20e4fd6dd.
3.10.2 is OK.

@code-asher
Copy link
Member

code-asher commented Jul 15, 2021 via email

@lz1998
Copy link

lz1998 commented Sep 11, 2021

It's possible it was re-introduced, we had a bit of a snafu with the patches.

3.11.1 CSS is still incorrect.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 13, 2021

@lz1998 I think it has to do with resources being blocked due to CSP.

See #4131

This should be resolved in the next release.

@coder coder locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants