Patch VS Code to wait for storage write #2049
Conversation
| * operation to either the current workspace only or all workspaces. | ||
| */ | ||
| - store(key: string, value: string | boolean | number | undefined | null, scope: StorageScope): void; | ||
| + store(key: string, value: string | boolean | number | undefined | null, scope: StorageScope): Promise<void> | void; |
There was a problem hiding this comment.
There are a bunch of tests that implement this interface. We could modify them all to return promises instead of void but it would increase the patch size a decent amount.
|
It looks like my version of git outputs index hashes that are 10 characters in length while the version used by the last person to generate the patch outputs 11 characters. As far as I can tell this isn't configurable yet (it will be in the next version). But I'm thinking we should modify the patch script to use |
VS Code has a short delay before writing storage (probably to queue up rapid changes). In the web version of VS Code this happens on the client which means if the page is reloaded before the delay expires the write never happens. Storage updates are already promises so this simply returns the promise returned by the delayer so it won't resolve until the write actually happens. Fixes #2021.
code-asher
force-pushed
the
vscode-storage
branch
from
6f33ea4 to
7614045
Compare
|
I removed the extraneous hash updates. 😄 |
Sounds good, go ahead and do that! |
|
In a separate commit of course. |
Confirmed that it fixes rust-lang/rust-analyzer#5892 (reported in #2021).