globalState is not persisted across extension updates #2021
Comments
Veetaha
changed the title
|
cc @code-asher |
|
I can replicate with: I think that (in the web version of VS Code at least) the storage file isn't written to immediately but rather after a delay and reloading for some reason interrupts that delay causing it to never write (further supported by the fact that adding a 1s timeout around the reload makes it work). Hopefully will be able to track down why the write gets canceled and get it fixed today. |
code-asher
added a commit
that referenced
this issue
Sep 2, 2020
VS Code has a short delay before writing storage (probably to queue up rapid changes). In the web version of VS Code this happens on the client which means if the page is reloaded before the delay expires the write never happens. Storage updates are already promises so this simply returns the promise returned by the delayer so it won't resolve until the write actually happens. Fixes #2021.
code-asher
added a commit
that referenced
this issue
Sep 2, 2020
VS Code has a short delay before writing storage (probably to queue up rapid changes). In the web version of VS Code this happens on the client which means if the page is reloaded before the delay expires the write never happens. Storage updates are already promises so this simply returns the promise returned by the delayer so it won't resolve until the write actually happens. Fixes #2021.
code-asher
added a commit
that referenced
this issue
Sep 2, 2020
VS Code has a short delay before writing storage (probably to queue up rapid changes). In the web version of VS Code this happens on the client which means if the page is reloaded before the delay expires the write never happens. Storage updates are already promises so this simply returns the promise returned by the delayer so it won't resolve until the write actually happens. Fixes #2021.
code-asher
added a commit
that referenced
this issue
Sep 3, 2020
VS Code has a short delay before writing storage (probably to queue up rapid changes). In the web version of VS Code this happens on the client which means if the page is reloaded before the delay expires the write never happens. Storage updates are already promises so this simply returns the promise returned by the delayer so it won't resolve until the write actually happens. Fixes #2021.
code-asher
added a commit
that referenced
this issue
Sep 3, 2020
VS Code has a short delay before writing storage (probably to queue up rapid changes). In the web version of VS Code this happens on the client which means if the page is reloaded before the delay expires the write never happens. Storage updates are already promises so this simply returns the promise returned by the delayer so it won't resolve until the write actually happens. Fixes #2021.
|
Should we close this? |
|
Recently we've switched to closing the issues once a release with the fix goes out so let's leave it open for now! |
|
We recently started using milestones so we can close this now and track whether it's released using the milestone. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our extension fails to work on code-server (rust-lang/rust-analyzer#5892).
The problem is that we use
globalState. We expect the contents ofglobalStateto persist across the extension version updates. Even though this is not mentioned invscodeAPI docs, but originalvscodedoes persist it, butcode-serverdoesn't.For example we check for new nightly extension release and record it in
globalStatelike this.But when we programmatically install the extension from VSIX and reload the window, code-server clears the persistent storage.
Meta
Google Chrome Version 84.0.4147.125 (Official Build) (64-bit)Ubuntu 20.04.1 LTScode-serveron my local PC, so probably same as Local OS)x86_64my PCcode-server --version:3.4.148f7c27The text was updated successfully, but these errors were encountered: