Skip to content

Fix npm post install to fetch extension dependencies #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Sep 2, 2020

Closes #1961

@nhooyr nhooyr requested a review from code-asher September 2, 2020 01:39
@code-asher
Copy link
Member

It seems that the final package.json that VS Code ships for each builtin extension has the dependencies portion removed so yarn ends up not installing anything.

We could prevent that deletion: https://github.com/microsoft/vscode/blob/1.48.2/build/lib/extensions.ts#L73

Or we could only add back the dependencies specifically marked as external in the extension's webpack configuration since the rest will have been bundled.

@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 4, 2020

We could prevent that deletion: https://github.com/microsoft/vscode/blob/1.48.2/build/lib/extensions.ts#L73

That's what I'll do!

@nhooyr nhooyr closed this Oct 7, 2020
@nhooyr nhooyr deleted the ext-45c3 branch October 7, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants