npm module doesn't install extension dependencies #1961
Comments
|
I tried this out with the |
|
Thanks for the tip. Here's the output from Log (Remote Extension Host). I've also tried updating the node installation to v12.18.3 |
|
It looks like one of the dependencies for the extension is missing. It doesn't look like our image since we put code-server in There should be a directory at One workaround is to manually install the missing dependency: |
code-asher
added
the
waiting-for-info
|
Please try using the latest version anyway. |
|
Thanks y'all. You're right @code-asher , this isn't the image direct from cdr. I'm using this docker image: https://github.com/linuxserver/docker-code-server I initially thought it was a code-server problem but it may be a problem with that linuxserver docker instead or how it's being installed with Unraid... Just odd other folks haven't ran into a similar problem on such a popular feature. In any case, thanks for the help. |
|
@code-asher @nhooyr We install code-server via But that doesn't seem to compile the modules like emmet. Is there a recommended way to have everything compiled? By the way, the reason we don't have 3.4.1 is because the naming convention issue with the latest github stable release breaks our ci, so we decided to skip that release. We didn't realize it would be quite a long time before the next release. EDIT: As a test, I built a local image for 3.4.1 and that has more related issues. It seems |
|
Sounds like our npm package needs some work! |
code-asher
changed the title
code-asher
added
needs-investigation
and removed
waiting-for-info
|
Very weird, the .deb is generated from taking then npm package and installing it so if there is a bug with the npm package, it should occur in our Dockerfile as well. |
|
Only difference seems to be we're passing |
|
Oh wait is it because we delete |
We do it ourselves afterwards. |
|
My point is that it's unlikely there's something wrong with the build process otherwise we'd be seeing many reports of the same issue with our standalone releases as well right. |
|
I mean there's nothing that moves into the extension directories (like |
|
Since I think that's in the main postinstall and not the one in |
|
One idea would be to |
|
As for why this happens, maybe the npm publishing process leaves out any directories called |
Ahhh true, I guess we're that at some point early in the build process! Probably when building VS Code. @aptalca Best if you guys switch to our install script for now as that'll use a |
nhooyr
changed the title
|
We can't do the deb because you don't publish an arm32 package |
|
I dug in a little bit more. Switched to using Looking at the earlier comment about running yarn in the emmet folder, when I do that, the node_modules folder is created in there, but there is no |
|
Ah yup, looks like VS Code strips the |
|
@nhooyr @code-asher thanks guys, I can confirm that these built in extensions now work with an npm/yarn install of 3.6.0 @tonywu3 emmet abbrev is working out of the box now on the latest |
|
Thanks everyone for your hard work! |
Did a fresh install of the docker image and keep running into the following error:
Running the contributed command: 'emmet.expandAbbreviation' failed.My only setting is:
{ "emmet.triggerExpansionOnTab": true }No other extensions installed/enabled. Straight from installation to opening a new html file and trying to expand
!or
ul>li*5results in that error.
Current version details:
The text was updated successfully, but these errors were encountered: