Skip to content

Update VS Code to 1.47.0 #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Update VS Code to 1.47.0 #1874

merged 1 commit into from
Jul 10, 2020

Conversation

code-asher
Copy link
Member

Pretty straightforward update.

  • Refactor readFileStream in file system provider to use VS Code's instead of copying the code.
  • Update fix that allows any extension to be installed since that area was refactored in 1.47.0.
  • Update location of Firefox scm viewlet fix (it was moved to another file).
  • Remove csp fix since it's included in 1.47.0.

@code-asher
Copy link
Member Author

code-asher commented Jul 9, 2020

Also added a trailing slash to the webview endpoint. It seems this is passed to extensions as the source for CSP tags now, and without the trailing slash the browser refuses to load the resources for some reason. This was causing the pdf extension to break, for example.

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry it took a while, the patch is very confusing to review.

looks good to me.


+ // NOTE@coder: Fall back to installing on the remote server.
+ if (this.extensionManagementServerService.remoteExtensionManagementServer) {
+ return this.extensionManagementServerService.remoteExtensionManagementServer.extensionManagementService.installFromGallery(gallery);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good god 🤮

@code-asher code-asher merged commit fb9ebeb into master Jul 10, 2020
@code-asher code-asher deleted the vscode-1.47.0 branch July 10, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants