Skip to content

Settings.json autosuggestion broken in v3.3.0 #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nathanrpage97 opened this issue May 18, 2020 · 13 comments · Fixed by #1671
Closed

Settings.json autosuggestion broken in v3.3.0 #1667

nathanrpage97 opened this issue May 18, 2020 · 13 comments · Fixed by #1671
Assignees
@nhooyr
Labels
bug Something isn't working
Milestone
v3.3.1

Comments

@nathanrpage97
Copy link

Code server autosuggestions for settings.json is broken in v3.3.0. It just provides an empty suggestion box:
image

I'm not sure if it is settings.json specific or a schema level issue.
@kylecarbs
Copy link
Member

Looking into this now.

@biplobsd
Copy link

Looking into this now.
I think your maybe read release Breaking Changes point.. i found!

@nhooyr
Copy link
Contributor

nhooyr commented May 18, 2020

@nathanrpage97 Are you using windows? If so this is a duplicate of #1659

@nhooyr nhooyr closed this as completed May 18, 2020
@nathanrpage97
Copy link
Author

No, I'm running on a dockerized rpi4 w/ arm64 build. When I revert to v3.2.0 autosuggestion works fine:

image

@nhooyr
Copy link
Contributor

nhooyr commented May 18, 2020

@nathanrpage97 Sorry, to clarify I meant if you're accessing from windows.

@nathanrpage97
Copy link
Author

Oh, no Im accessing from a mac.

@nhooyr
Copy link
Contributor

nhooyr commented May 18, 2020

Thanks for the quick responses, just confirmed, seeing this issue as well.

Oddly if you remove the second quote, autocomplete shows up.

Not sure if this is a VS Code bug.

@nhooyr nhooyr reopened this May 18, 2020
@nhooyr nhooyr added the bug Something isn't working label May 18, 2020
@nathanrpage97
Copy link
Author

Just to confirm you mean a non-empty list of autocomplete?

@nhooyr
Copy link
Contributor

nhooyr commented May 18, 2020

Yup

image

@nathanrpage97
Copy link
Author

So I just checked, it works without quotes and with one quote but not with fully surrounding quotes. I don't see this issue in vscode 1.45.1 and it doesn't show up as a fix in that patch.

@nhooyr nhooyr self-assigned this May 18, 2020
@nhooyr nhooyr mentioned this issue May 18, 2020
Closed
@nhooyr nhooyr added this to the v3.3.1 milestone May 18, 2020
@nhooyr nhooyr mentioned this issue May 18, 2020
Merged
nhooyr added a commit that referenced this issue May 18, 2020
@nhooyr
Pin to vscode 1.45.1
ce9d14d 
1.46 isn't released yet and has bugs.

Closes #1667
nhooyr added a commit that referenced this issue May 18, 2020
@nhooyr
Release v3.3.1
5f94d5a 
This release fixes bugs introduced with the release of v3.3.0

- We've reverted to VS Code 1.45.1 due to bugs in 1.46 #1667
- Accessing code-server from a web browser on Windows has been fixed #1642
- Search in project has been fixed #1665
- The glibc requirement on static releases has been lowered to v2.19 #1656
@nhooyr nhooyr mentioned this issue May 18, 2020
Merged
@sterlinm
Copy link

I'm just checking in and really appreciate the project. It looks like code-server has been pinned to VS Code 1.45.1 since encountering this issue. Will future plans catch back up to VS Code (currently on 1.47.0 I believe)? Just curious. Thanks!

@nhooyr
Copy link
Contributor

nhooyr commented Jul 14, 2020

@sterlinm See #1874

Will tag a release some point soon.

@sterlinm
Copy link

@nhooyr Thanks so much for the reply! Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging a pull request may close this issue.

Pin to vscode 1.45.1 coder/code-server
5 participants
@sterlinm @kylecarbs @nhooyr @nathanrpage97 @biplobsd