Unset $PASSWORD after grabbing it #1602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
May 4, 2020
code-asher
reviewed
May 4, 2020
src/node/entry.ts
Outdated
| @@ -90,6 +90,7 @@ const main = async (args: Args): Promise<void> => { | |||
| } else { | |||
| logger.info(" - No authentication") | |||
| } | |||
| process.env.PASSWORD = undefined | |||
There was a problem hiding this comment.
This doesn't really matter but since this will set it to the literal string "undefined" should we do delete process.env.PASSWORD instead?
There was a problem hiding this comment.
Forgot, it's so dumb...
|
In the future we ought to add a flag/config file option and remove docs on $PASSWORD to avoid issues like these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1583