Skip to content

Remove $PASSWORD from ENV after reading it. #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Grimeton opened this issue Apr 30, 2020 · 1 comment · Fixed by #1602
Closed

Remove $PASSWORD from ENV after reading it. #1583

Grimeton opened this issue Apr 30, 2020 · 1 comment · Fixed by #1602
Assignees
@nhooyr
Labels
bug Something isn't working

Comments

@Grimeton
Copy link

Hi,

patch the server so that $PASSWORD gets unset in the environment of the server after it has been read, because else it will get inherited to all the shells the server starts in a terminal...

KR,

G.
@nhooyr
Copy link
Contributor

nhooyr commented May 1, 2020

Great catch!

@nhooyr nhooyr self-assigned this May 1, 2020
@nhooyr nhooyr added the bug Something isn't working label May 1, 2020
nhooyr added a commit that referenced this issue May 4, 2020
@nhooyr
Unset $PASSWORD after grabbing it
61d769f 
Closes #1583
@nhooyr nhooyr mentioned this issue May 4, 2020
Merged
nhooyr added a commit that referenced this issue May 5, 2020
@nhooyr
Unset $PASSWORD after grabbing it
1898dea 
Closes #1583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unset $PASSWORD after grabbing it coder/code-server
2 participants
@Grimeton @nhooyr