Skip to content

Deprecate --host and --port in favour of --bind-addr #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2020
Merged

Deprecate --host and --port in favour of --bind-addr #1562

merged 2 commits into from
Apr 28, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Apr 27, 2020

No description provided.

@nhooyr nhooyr requested a review from code-asher as a code owner April 27, 2020 13:23
code-asher
code-asher reviewed Apr 27, 2020
View reviewed changes
@nhooyr nhooyr requested a review from code-asher April 28, 2020 18:15
@nhooyr nhooyr merged commit 37184f4 into master Apr 28, 2020
@nhooyr nhooyr deleted the bindaddr branch April 28, 2020 18:33
@nhooyr nhooyr mentioned this pull request Apr 28, 2020
Closed
@antofthy
Copy link

antofthy commented Apr 28, 2020 •
edited
Loading

So exactly what changed? Just fixing it is no good if the users don't know what changed!

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 28, 2020

@antofthy If you run a prerelease, you can run --help to see the --bind-addr option and its description. It just combines --host and --port as described in the original issue. When we create a new release, we'll be sure to mention this option in the notes.

@antofthy
Copy link

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhooyr @antofthy @code-asher