Skip to content

Remove --host and --port in favour of --bind-addr #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhooyr opened this issue Sep 20, 2019 · 6 comments
Closed

Remove --host and --port in favour of --bind-addr #1013

nhooyr opened this issue Sep 20, 2019 · 6 comments
Assignees
Labels
enhancement Some improvement that isn't a feature

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Sep 20, 2019

More ergonomic and in line with other modern tools.

E.g. --bind-addr=localhost:8080

@sr229 sr229 added enhancement Some improvement that isn't a feature good-beginner-issue labels Sep 20, 2019
@sr229
Copy link
Contributor

sr229 commented Sep 24, 2019

bind-addr has more keystrokes than address so I think we should go for address instead.

@nhooyr
Copy link
Contributor Author

nhooyr commented Sep 24, 2019

Address isn't clear on what it is. Is it the external address at which the code-server is available? bind-addr makes it very clear and there is precedent for it in a lot of tooling I've used before.

@antofthy
Copy link

antofthy commented Oct 4, 2019

I also want to see --bind-address implemented as separate to --host as they are NOT the same

If I give --host machine.some.domain code server will then display a URL with the resolved IP
of that hostname. On our systems that IP is the internal Docker subnet IP, and not the IP the user will use. Our users need to use the given argument as this points to a wildcard proxy to a docker swarm.

Basically there are two host names involved...
1/ binding host/IP
2/ hostname used for redirects and reporting to user

The second could be made part of --base-path though it will make it more of a --base-url option

However the URL reported to the user to use on startup, also does not include --base-path when it probably should!

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 28, 2020

Closed by #1562

@antofthy
Copy link

So exactly what changed? Just fixing it is no good if the users don't know what changed!

@nhooyr
Copy link
Contributor Author

nhooyr commented Apr 28, 2020

If I give --host machine.some.domain code server will then display a URL with the resolved IP
of that hostname. On our systems that IP is the internal Docker subnet IP, and not the IP the user will use. Our users need to use the given argument as this points to a wildcard proxy to a docker swarm.

I'm not I understand what you mean exactly. Where will code-server display this URL and why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

4 participants