[Bug]: Login GitHub #4795

Stanixia · 2022-01-26T17:09:35Z

Is there an existing issue for this?

I have searched the existing issues

OS/Web Information

Web Browser: Version 1.34.81 Chromium: 97.0.4692.99 (Build officiel) (64 bits)
Local OS: Windows 10
Remote OS: Docker (codercom/code-server:latest)
Remote Architecture:
code-server --version: 4.0.1

Steps to Reproduce

git push -u origin main

Expected

Have github authentication message

Actual

Error committing github

Logs

No response

Screenshot/Video

Does this issue happen in VS Code?

I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

I am using HTTPS.

Notes

No response

The text was updated successfully, but these errors were encountered:

jsjoeio · 2022-01-26T21:26:08Z

Argh. I can't reproduce locally on macOS + Brave but obviously that's because I've already authenticated with Git. We've had this in the past and I know @code-asher has fixed it.

What happens if you open the Command Palette > "Publish to GitHub" > enter your PAT? Does that work?

Stanixia · 2022-01-27T08:44:15Z

Hi,

It's ok if I use git remote add origin and PAT

I use Brave and Windows or MacOs but my setup is a Ubuntu 20.04 in a VPS and Docker container in my VPS
I also use Nginx Proxy Manager for external with a SSL

It's possible the proxy doesn't work with github callback ?

jsjoeio · 2022-01-27T23:16:04Z

It's ok if I use git remote add origin and PAT

awesome!

It's possible the proxy doesn't work with github callback ?

Possibly 🤔 I wish I knew how to reset my Git auth locally so I could actually try to reproduce. There's a possibility it's broken and not related to your proxy

SelfMadeSystem · 2022-01-28T18:33:55Z

Happens on MacOS BigSur (11.4) and Arch Linux, both with firefox and vivaldi (code-server hosted on arch)

jsjoeio · 2022-01-28T21:58:42Z

Thanks @True-cc!

What happens if you open the Command Palette > "Publish to GitHub" > enter your PAT? Does that work?

For now you can use this workaround^

Stanixia · 2022-01-31T16:04:04Z

Settings Sync

plckr · 2022-02-12T23:05:13Z

What happens if you open the Command Palette > "Publish to GitHub" > enter your PAT? Does that work?

@jsjoeio this method doesn't work for me because the window doesn't let me insert the PAT, it opens the error link directly

$ code-server --version
4.0.2 5cdfe74686aa73e023f8354a9a6014eb30caa7dd

jsjoeio · 2022-02-14T20:58:33Z

@ricreis394 can you share a video?

plckr · 2022-02-14T22:20:19Z

@ricreis394 can you share a video?

@jsjoeio sure, here it goes

jsjoeio · 2022-02-14T22:43:12Z

@ricreis394 Ah that's a different flow than the one I'm referring to. Mine asks for a PAT inside code-server 🤔 I wonder if it's cause I'm using the PWA. I have no idea

What happens if you hit cancel?

plckr · 2022-02-14T22:50:05Z

What happens if you hit cancel?

@jsjoeio It just cancels. Won't do anything
I'm using code behind a reverse proxy (nginx), at first I thought that could be the problem, but nope. The gif I sent is from direct IP connection, no redirections

The strange thing is, before version 4, I was logged in on github, don't know why it logged out...

jsjoeio · 2022-02-14T23:06:24Z

@ricreis394 hmm...I mean we had a big upgrade for VS Code in 4 so maybe it reset there? I'm not sure.

I don't know when I'll be able to look into this cause I can't easily reproduce :( But I'll add it to the high priority list. Or see if I can add it in next month's sprint.

jsjoeio · 2022-02-14T23:07:13Z

Heads-up: for anyone else experiencing this, please give a thumbs-up on the issue description! That will help me see how many people are affected by this and prioritize properly.

plckr · 2022-02-14T23:12:39Z

@jsjoeio anything I can do to help debug the issue?

chrisdburr · 2022-02-15T07:09:55Z

Not sure if this helps, but I can push to GH using username and PAT after cancelling the default login option. However, it asks for the PAT each time I try to push a commit.

Information:

OS: Debian Bullseye
Code-Server: Docker Container (Latest)
Browser: iPad (Safari)

jsjoeio · 2022-02-15T17:44:57Z

@jsjoeio anything I can do to help debug the issue?

Hmm...you were very helpful with the video! I wish there was a way to reproduce it consistently. One thing you could do is grab the authorization URL that opens in the browser (be sure to remove the auth token from the URL) and share it here?

I know we've patched that in the past so I'm guessing we lost that patch. cc @code-asher

However, it asks for the PAT each time I try to push a commit.

Thank you @chrisdburr! That is usually a separate error that means your credential helper isn't caching your credentials. This has helped me in the past.

code-asher · 2022-02-15T19:37:31Z

You are probably right about it being lost. I will need to be in this code soon for other reasons so I will take a look.

plckr · 2022-02-15T23:50:31Z

Hmm...you were very helpful with the video! I wish there was a way to reproduce it consistently. One thing you could do is grab the authorization URL that opens in the browser (be sure to remove the auth token from the URL) and share it here?

@jsjoeio

https://vscode-auth.github.com/authorize/?callbackUri=<ip>:8443/callback%253Fvscode-requestId%253D<hiddenRequestId>%2526vscode-scheme%253Dcode-oss%2526vscode-authority%253Dvscode.github-authentication%2526vscode-path%253D%25252Fdid-authenticate&scope=repo%20workflow&state=<hiddenState>&responseType=code&authServer=https://github.com

Not sure what to hide, so I hidden the requestId and the State

steilerDev · 2022-02-18T08:14:41Z

Based on the reports, this might be due to our setup. I'm experiencing the same issue with my docker (codercom/code-server:latest) + nginx-proxy (with lets-encrypt support).

This issue happens on all browsers I tried (latest Chrome/Safari/Brave on macOS + Safari on iPad).

The workaround in #1883 still works. (Unfortunately the Github Login seems to be stored locally in the browser, which means I'd need to perform this everytime I'm switching clients. On the bright side, using inkognito mode should give you a 'clean' instance to reproduce @jsjoeio)

In my opinion storing and using a PAT on the server would be the best way, so I won't need to re-authenticate when using a new client. (But I'm new to this project, so I have no idea if this is even remotely possible :D )

P.S.: About Screen:

code-server: v4.0.2
VS Code: v1.63.0
Commit: 5cdfe74686aa73e023f8354a9a6014eb30caa7dd
Date: 2022-01-27T22:22:39Z (3 wks ago)
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/98.0.4758.102 Safari/537.36

P.P.S: The request is similiar to the one above:
https://vscode-auth.github.com/authorize/?callbackUri=https://coder.<domain>.net/callback%253Fvscode-requestId%<reqID>%2526vscode-scheme%253Dcode-oss%2526vscode-authority%253Dvscode.github-authentication%2526vscode-path%253D%25252Fdid-authenticate&scope=repo%20workflow&state=<state>&responseType=code&authServer=https://github.com

cnfatal · 2022-02-20T05:29:31Z

#1883 (comment) resolved temporarily

plckr · 2022-02-20T17:48:05Z

Used the below method and worked as a temporary workaround

CTRL + Shift + P ▶️ Publish to Github
Will show a window asking permission to allow signin, press Allow
Extract the state from the url opened and insert that in this url https://vscode-auth.github.com/authorize/?callbackUri=vscode://vscode.github-authentication/did-authenticate&scope=repo,workflow&state=<insert-state-from-code-server-here>&responseType=code
open the new url in the browser, and allow sign in, after submitting it will generate a new url/code. Copy that generated url that will be something like this: vscode://vscode.github-authentication/did-authenticate?code=<code>&state=<state>
go to code-server and click on "Signing in to GitHub" on the taskbar. It then will ask for the URI and paste the url
And boom, you're logged in!

Credits: #1883 (comment)

steilerDev · 2022-02-20T19:49:05Z

Build a little script using the method above to get the URL.

#!/bin/bash

read -p "VSCode GH Auth URL:" URL

STATE=$(echo $URL | awk -F'[=&]' '{print $6}')

NEW_URL="https://vscode-auth.github.com/authorize/?callbackUri=vscode://vscode.github-authentication/did-authenticate&scope=repo,workflow,read:user,user:email&state=${STATE}&responseType=code"

clear
echo 
echo "1. Access URL below & grant access"
echo
echo $NEW_URL
echo
echo "2. Don't use 'Open with VSCode...'"
echo "3. Copy the token."
echo "4. Switch back to VS code."
echo "5. Click Signing in to github.com... in the status bar."
echo "6. Paste the token and hit enter."

EDIT: As you can see this requests for scope=repo,workflow,read:user,user:email, since I'm using the Workflow Plugin and the Issues Plugin. scope=repo should be sufficient for the git integration.

SelfMadeSystem · 2022-02-21T00:02:53Z

If nothing else works, maybe having that within code-server could be the best solution?

aliuq · 2022-02-21T16:27:55Z

me too, same enviroment with u

jsjoeio · 2022-02-22T21:23:20Z

Thank you @ricreis394 for the solution and @steilerDev for the killer script 🔥

Hoping this is a quick fix on our end. We had yesterday off but we're back this week. Thanks for the patience!

jsjoeio · 2022-02-24T17:11:26Z

A fix will be available in the next release!

aliuq · 2022-02-24T17:51:11Z

A fix will be available in the next release!

Thank you

* Restore auth relay patch Fixes coder/code-server#4795. * Fix callback URIs behind a sub-path

Stanixia added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jan 26, 2022

jsjoeio added waiting-for-info Waiting for more information from submitter and removed bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jan 26, 2022

jsjoeio added needs-investigation This issue needs to be further investigated high-priority This issue needs to be resolved ASAP and removed waiting-for-info Waiting for more information from submitter labels Jan 28, 2022

jsjoeio added this to the On Deck - High Priority milestone Jan 28, 2022

code-asher self-assigned this Feb 15, 2022

code-asher modified the milestones: On Deck - High Priority, 4.0.3 Feb 15, 2022

jsjoeio mentioned this issue Feb 17, 2022

Cannot sign in to Github account #1883

Closed

code-asher closed this as completed Feb 23, 2022

code-asher added a commit to coder/vscode that referenced this issue Feb 24, 2022

Fix GitHub authentication (#47)

676edaa

* Restore auth relay patch Fixes coder/code-server#4795. * Fix callback URIs behind a sub-path

jsjoeio mentioned this issue Feb 25, 2022

[Testing]: write e2e test for GitHub auth patch #4914

Closed

code-asher removed the needs-investigation This issue needs to be further investigated label Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: Login GitHub #4795

[Bug]: Login GitHub #4795

Stanixia commented Jan 26, 2022 •

edited

Loading

jsjoeio commented Jan 26, 2022

Stanixia commented Jan 27, 2022

jsjoeio commented Jan 27, 2022

SelfMadeSystem commented Jan 28, 2022 •

edited

Loading

jsjoeio commented Jan 28, 2022

Stanixia commented Jan 31, 2022

plckr commented Feb 12, 2022 •

edited

Loading

jsjoeio commented Feb 14, 2022

plckr commented Feb 14, 2022 •

edited

Loading

jsjoeio commented Feb 14, 2022

plckr commented Feb 14, 2022 •

edited

Loading

jsjoeio commented Feb 14, 2022 •

edited

Loading

jsjoeio commented Feb 14, 2022

plckr commented Feb 14, 2022

chrisdburr commented Feb 15, 2022

jsjoeio commented Feb 15, 2022

code-asher commented Feb 15, 2022

plckr commented Feb 15, 2022 •

edited by jsjoeio

Loading

steilerDev commented Feb 18, 2022 •

edited

Loading

cnfatal commented Feb 20, 2022 •

edited

Loading

plckr commented Feb 20, 2022

steilerDev commented Feb 20, 2022 •

edited

Loading

SelfMadeSystem commented Feb 21, 2022

aliuq commented Feb 21, 2022

jsjoeio commented Feb 22, 2022

jsjoeio commented Feb 24, 2022

aliuq commented Feb 24, 2022 •

edited

Loading

[Bug]: Login GitHub #4795

[Bug]: Login GitHub #4795

Comments

Stanixia commented Jan 26, 2022 • edited Loading

Is there an existing issue for this?

OS/Web Information

Steps to Reproduce

Expected

Actual

Logs

Screenshot/Video

Does this issue happen in VS Code?

Are you accessing code-server over HTTPS?

Notes

jsjoeio commented Jan 26, 2022

Stanixia commented Jan 27, 2022

jsjoeio commented Jan 27, 2022

SelfMadeSystem commented Jan 28, 2022 • edited Loading

jsjoeio commented Jan 28, 2022

Stanixia commented Jan 31, 2022

plckr commented Feb 12, 2022 • edited Loading

jsjoeio commented Feb 14, 2022

plckr commented Feb 14, 2022 • edited Loading

jsjoeio commented Feb 14, 2022

plckr commented Feb 14, 2022 • edited Loading

jsjoeio commented Feb 14, 2022 • edited Loading

jsjoeio commented Feb 14, 2022

plckr commented Feb 14, 2022

chrisdburr commented Feb 15, 2022

jsjoeio commented Feb 15, 2022

code-asher commented Feb 15, 2022

plckr commented Feb 15, 2022 • edited by jsjoeio Loading

steilerDev commented Feb 18, 2022 • edited Loading

cnfatal commented Feb 20, 2022 • edited Loading

plckr commented Feb 20, 2022

steilerDev commented Feb 20, 2022 • edited Loading

SelfMadeSystem commented Feb 21, 2022

aliuq commented Feb 21, 2022

jsjoeio commented Feb 22, 2022

jsjoeio commented Feb 24, 2022

aliuq commented Feb 24, 2022 • edited Loading

Stanixia commented Jan 26, 2022 •

edited

Loading

SelfMadeSystem commented Jan 28, 2022 •

edited

Loading

plckr commented Feb 12, 2022 •

edited

Loading

plckr commented Feb 14, 2022 •

edited

Loading

plckr commented Feb 14, 2022 •

edited

Loading

jsjoeio commented Feb 14, 2022 •

edited

Loading

plckr commented Feb 15, 2022 •

edited by jsjoeio

Loading

steilerDev commented Feb 18, 2022 •

edited

Loading

cnfatal commented Feb 20, 2022 •

edited

Loading

steilerDev commented Feb 20, 2022 •

edited

Loading

aliuq commented Feb 24, 2022 •

edited

Loading