[Testing]: write e2e test for GitHub auth patch

[jsjoeio]

May need to talk to @code-asher about this but I'd like to write an e2e in test so #4795 doesn't happen again.

Related

• Fix GitHub authentication vscode#47

[jsjoeio]

Notes

e2e tests shouldn't rely on network connections since we want our tests to be deterministic and not fail due to network errors. Therefore my thinking for an e2e test for this is to do something like this:

1. launch code-server
2. Command Palette > Publish to GitHub
3. Select Allow
4. Assert URL opened includes `auth.code-server.dev``

@code-asher What are your thoughts? Both on this e2e idea and my hypothetical approach.

Or is there a way I could unit test this instead?

My end goal is to prevent regressions and less about how we get there.

[code-asher]

Hmm unit test seems tricky to me, unless perhaps we can add the test on the Code side (I assume they have unit tests). The proposed steps I think are sufficient to prove that we have properly patched the relay server. I think we may want to also assert that the right redirect URL is in a query param.