Skip to content

Use nbin for native modules #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kylecarbs opened this issue Apr 4, 2019 · 0 comments · Fixed by #472
Closed

Use nbin for native modules #425

kylecarbs opened this issue Apr 4, 2019 · 0 comments · Fixed by #472
Assignees
@code-asher
Labels
blocked This issue cannot proceed due to external factors
Milestone
April 2019

Comments

@kylecarbs
Copy link
Member

Should use binary.writeModule(...).

Blocked by: coder/nbin#4
@kylecarbs kylecarbs added the blocked This issue cannot proceed due to external factors label Apr 4, 2019
@kylecarbs kylecarbs added this to the April 2019 milestone Apr 4, 2019
@code-asher code-asher removed the blocked This issue cannot proceed due to external factors label Apr 9, 2019
@code-asher code-asher self-assigned this Apr 9, 2019
@code-asher code-asher mentioned this issue Apr 9, 2019
Merged
3 tasks
@code-asher code-asher added the blocked This issue cannot proceed due to external factors label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
blocked This issue cannot proceed due to external factors
Projects
None yet
Milestone
April 2019
Development

Successfully merging a pull request may close this issue.

Update node to 10.15.1 coder/code-server
2 participants
@kylecarbs @code-asher