This repository was archived by the owner on May 23, 2021. It is now read-only.

Extract native modules uniquely #4

Closed

kylecarbs opened this issue Apr 4, 2019 · 1 comment

Member

kylecarbs commented Apr 4, 2019

https://github.com/codercom/nbin/blob/74da4b366f5c37ea47d83d3e73384e5a3307e00c/node.patch#L108

We don't check if the .node file extracted is different than the .node file in the binary.

We could do this by hashing the embedded .node file, or by checking size for now.

The text was updated successfully, but these errors were encountered:

kylecarbs mentioned this issue

Use nbin for native modules coder/code-server#425

Closed

Member

code-asher commented Apr 9, 2019

We've decided to keep extracting them each time since it'll only happen once and might be less expensive than hashing anyway.

code-asher closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.