Skip to content

Add Archiver that creates modular JAR files using the JDK jar tool #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add Archiver that creates modular JAR files using the JDK jar tool #84

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42892e8
Bump version to 3.6 for the upcoming changes
plamentotev Apr 8, 2018
24444fe
Add new method (postCreateArchive) to AbstractArchiver
plamentotev Apr 8, 2018
38e2880
Add base test class for JAR archivers
plamentotev Apr 8, 2018
54fe62b
Add base class for creating modular JAR files.
plamentotev Apr 8, 2018
3c2dc6a
Add Archiver that creates modular JAR files using the JDK jar tool.
plamentotev Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</parent>

<artifactId>plexus-archiver</artifactId>
<version>3.5.1-SNAPSHOT</version>
<version>3.6-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do 3.6.0-SNAPSHOT instead ? I would suggest to have three digits.. ? WDYT ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last couple of releases are two digits. I don't know if there is any particular reason - I think @michael-o did the last release. Maybe he knows. Other than that I agree that with three digits is better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have agreed at some point to use semver with three digits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then I'll change it to 3.6.0

<name>Plexus Archiver Component</name>

<scm>
Expand Down