Add Archiver that creates modular JAR files using the JDK jar tool #84
Conversation
The purpose of the method is to allow subclasses to augment the archive after it is created. This is going to be used to update Jar archives to modular Jar archives.
We're going to add Archiver implementation that could be used for both regular and modular JAR archives. This base test class is going to be useful to reuse tests between it and the existing JarArchiver.
| @@ -10,7 +10,7 @@ | |||
| </parent> | |||
|
|
|||
| <artifactId>plexus-archiver</artifactId> | |||
| <version>3.5.1-SNAPSHOT</version> | |||
| <version>3.6-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Can we do 3.6.0-SNAPSHOT instead ? I would suggest to have three digits.. ? WDYT ?
There was a problem hiding this comment.
The last couple of releases are two digits. I don't know if there is any particular reason - I think @michael-o did the last release. Maybe he knows. Other than that I agree that with three digits is better.
There was a problem hiding this comment.
We have agreed at some point to use semver with three digits.
There was a problem hiding this comment.
ok, then I'll change it to 3.6.0
|
Can you please squash before merging? |
|
@michael-o I'll squash it. You mean that 38e2880, 54fe62b and 3c2dc6a should be one commit or that both PRs should be one commit? |
|
Yes that means squashing ...to have only a single commit which represents the change and after merging it to master it's easier to understand in the history... |
As discussed on dev list I've created
Archiverthat allows the creation of modular JAR files and setting their module version and main class. The implementation usesjava.util.spi.ToolProviderso Java 9+ is required (it will run on Java 7+ but the version and main class will not be set). As discussed it does not support tool chain, but it is easy to add support if you think it is required.This PR depends on #83. As new method is added to the API i decided it's better to split it into two merge requests. If they approved I'll rebase and merge into master
/cc @rfscholte