Add support for symlinks in PlexusIoZipFileResourceCollection #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| private ZipFileResource( ZipArchiveEntry entry ) | ||
| { | ||
| super( entry.getName(), entry.getTime() == 1 ? PlexusIoResource.UNKNOWN_MODIFICATION_DATE : entry.getTime(), |
There was a problem hiding this comment.
Didnt you change the condition here ?
There was a problem hiding this comment.
Indeed I have. I should be entry.getTime() == -1 I'll fix it
There was a problem hiding this comment.
Now it should be correct 😄
krosenvold
added a commit
that referenced
this pull request
Dec 13, 2015
Add support for symlinks in PlexusIoZipFileResourceCollection
|
The duplication of this class is unfortunate, what's worse is that they have somewhat different logic. One of them used to be in plexus-io. Ubderstanding the difference between these two is a bit of detective work. I believe there is an IT IN maven-assembly-plugin that fails when one of these is simly merged into the other... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I forgot to add fix for
PlexusIoZipFileResourceCollectionin #11. It looks like one cannot update pull request once it's merged so I'm making new one.