Preserve symbolic links when using Archiver::addArchivedFileSet #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ZIP file is created the last modified time is stored in MS-DOS formated date(if it's in the valid range for MS-DOS time), but when it's read the last modification time from extra field data is used. When ZIP file is created from the content of other ZIP file created with third-party tool the last modified time might differ with one second. Modify ArchiveFileComparator so two ZIP files are still considered equal if their entries' last modified time vary only by one second.
krosenvold
added a commit
that referenced
this pull request
Nov 24, 2015
|
Merged, Thanks a lot ! |
|
Actually it looks like somehow I've missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plexus Archiver does support symbolic links in ZIP and tar archive formats. But if you try to add the content of one archive to another using
Archiver::addArchivedFileSet, you'll end up with zero byte ordinary files instead of the symbolic links in the original archive.This series of commits fixes that so symbolic links are properly preserved.