Skip to content

feat: flu hosp explore #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 8, 2023
Merged

feat: flu hosp explore #55

merged 12 commits into from
Nov 8, 2023

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Oct 31, 2023

closes #34
closes #12

  • add flu hosp code
  • factors out code common to both covid hosp and flu hosp
  • rewrites a bit of run.R to rely on env vars (recommend setting those in .Renviron) and removes dynamics-constants.R

@dshemetov dshemetov changed the base branch from main to ds/refactors October 31, 2023 23:17
@dshemetov dshemetov force-pushed the ds/flu-hosp-explore branch 3 times, most recently from be0cf77 to e680d53 Compare November 2, 2023 19:13
Base automatically changed from ds/refactors to main November 2, 2023 20:01
@dshemetov dshemetov force-pushed the ds/flu-hosp-explore branch from 4fd2c12 to 867ef32 Compare November 2, 2023 20:18
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of things that I think we need to fix/adjust; I'll add some commits for that

@dsweber2 dsweber2 added this to the Pipeline improvements milestone Nov 3, 2023
@dshemetov dshemetov marked this pull request as ready for review November 3, 2023 23:41
@dshemetov dshemetov force-pushed the ds/flu-hosp-explore branch from a491abe to f27f4cc Compare November 7, 2023 02:20

#' Make common targets for forecasting experiments
#' @export
make_shared_grids <- function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a function that should be more prominent in some way, as I'm guessing we're going to change it a fair amount.

@dshemetov dshemetov merged commit 4f16887 into main Nov 8, 2023
@dshemetov dshemetov deleted the ds/flu-hosp-explore branch November 8, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flu-hosp specific exploration make target factories
2 participants