Skip to content

confirm_insufficient_data needs NA and per-state checks #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsweber2 opened this issue Nov 2, 2023 · 2 comments
Closed

confirm_insufficient_data needs NA and per-state checks #59

dsweber2 opened this issue Nov 2, 2023 · 2 comments
Milestone
Pipeline improvem...

Comments

@dsweber2
Copy link
Contributor

dsweber2 commented Nov 2, 2023

The point of the function is to skirt around epipredict not checking for insufficient data to actually fit. Turns out it doesn't work if there are NAs. It also doesn't check if there's enough for each geo_value; I think that's actually probably ok, as long as one state can make a prediction we shouldn't get weird errors
@dsweber2 dsweber2 added this to the Pipeline improvements milestone Nov 2, 2023
@dsweber2
Copy link
Contributor Author

dsweber2 commented Nov 2, 2023 •
edited by dshemetov
Loading

This was noticed when adding flu-hosp because of some versioning issues this past summer #55

@dsweber2 dsweber2 changed the title confirm_insufficient_data needs NA and per-state checks confirm_insufficient_data needs NA and per-state checks Nov 3, 2023
@dshemetov dshemetov mentioned this issue Nov 7, 2023
Closed
@dshemetov
Copy link
Contributor

closed in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pipeline improvements
Development

No branches or pull requests
2 participants
@dshemetov @dsweber2