Skip to content

Lcb/wip vignettes demos dogfooding #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: dev
Choose a base branch
from

Conversation

brookslogan
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dsweber2 dsweber2 assigned dsweber2 and brookslogan and unassigned dsweber2 Jul 12, 2024
@dsweber2
Copy link
Contributor

closes #355

@brookslogan
Copy link
Contributor Author

brookslogan commented Apr 7, 2025

  • Re. backtesting: We have https://cmu-delphi.github.io/epipredict/articles/backtesting.html to point to, and with Handle version datetime or different resolution than time_value #653 some of the other discussion should be unnecessary. Though some of the archive manipulation patterns in the epipredict vignette make me a bit uncomfortable, but these are due to epiprocess shortcomings (lack of as_tibble(), dplyr/tidyr verbs, and a way to not lose info about implicit vs. explicit NAs from the archive format, during merges especially).
  • Latency part... is why I'm not just closing this. Might need updated now that there is revision_summary(), though revision_summary() examines things from a slightly different perspective. And there is plotting code we might want to still present or incorporate into functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants