-
Notifications
You must be signed in to change notification settings - Fork 8
Allow epix_slide
to access version history if desired
#259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow epix_slide
to access version history if desired
#259
Conversation
024bcf4
to
c6a7141
Compare
epix_slide
to access version history if desired
I don't really have any business reviewing the details of the code changes here. But please add some tests to illustrate/confirm the desired performance. |
When `x` is a grouped `epi_archive`, it must be cloned and ungrouped so basic checks on `max_version` can be done. The cloning step is expensive and is unnecessary when the call is invalid or when the archive is not grouped. Separate the fn calls to simplify logic and avoid the sometimes-unecessary `clone`.
Status:
In the meantime:
and maybe there's even a way to eliminate some awkward cloning by doing the right structure of whether the S3 method calls the R6 method or vice versa, not sure. But maybe we don't need to be too elegant here because we hope to get rid of the R6 stuff altogether sometime
|
Thanks for the |
You're proposing:
?
|
Also tweak the `grouped_epi_archive` variant to avoid regrouping, taking advantage of the availability of `private$ungrouped`.
Before: `epix_slide` with `all_versions=TRUE` provides the user computation an `epi_archive` with its `DT` set to a tibble, but is expected to be a data.table by `epi_archive` operations. After: the `$DT`s are now set to `data.table`s. Plus: add (nonthorough) tests that * the `$DT` class & key are properly set. * we can use `data.table`-dependent `epi_archive` methods in the user computations.
Hi Nat, sorry for the long delay. I've pushed a couple of changes:
I think we're still missing:
|
* Fix partial rename of variable `as_of_tbl` -> `as_of_df` in `epix_slide` implementation. * Fix some bad links: * Fix transposition of link text and destination * Fix link text containing formatting, which is not allowed * Re-`document()`
Implement
all_versions = TRUE
options forepix_slide
andas_of
with the goal of supporting revision-aware models.Closes #49.