Skip to content

Check compatibility of epix_slide output class with some previous versions #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brookslogan opened this issue Mar 29, 2023 · 2 comments
Closed

Check compatibility of epix_slide output class with some previous versions #294

brookslogan opened this issue Mar 29, 2023 · 2 comments
Labels
op-semantics Operational semantics; many potentially breaking changes here P1 medium priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Mar 29, 2023 •
edited
Loading

Encountered in #290, likely also #259. Seems like merge d8287cf took away the epi_df-producing behavior of d648910, which looks like it was inherited from e957781.
@brookslogan brookslogan added P1 medium priority op-semantics Operational semantics; many potentially breaking changes here labels Mar 29, 2023
@brookslogan
Copy link
Contributor Author

brookslogan commented Mar 29, 2023 •
edited
Loading

Above traceback mightappears to be bogus as the old default group_by behavior might have changed the results for the snippet I was testing.

@brookslogan
Copy link
Contributor Author

Grouping by geo_value, it looks like we started getting epi_df results in e957781. And still have them in dev. I thought we weren't getting them for grouped or ungrouped archives on lcb/make_epix_slide_more_like_reframe, but apparently that wasn't actually the case. Closing this issue as it appears to have just been a mixup with the testing on that branch + with the old default group_by.

@brookslogan brookslogan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
@brookslogan brookslogan changed the title epix_slide no longer outputs epi_dfs on dev branch; change and/or document Checking compatibility of epix_slide output class with some previous versions Mar 29, 2023
@brookslogan brookslogan changed the title Checking compatibility of epix_slide output class with some previous versions Check compatibility of epix_slide output class with some previous versions Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
op-semantics Operational semantics; many potentially breaking changes here P1 medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brookslogan