Removed as_tibble() calls in archive slide fun #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han-an-epi_df-incompatible-with-arx_forecaster
dajmcdon
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
@brookslogan This doesn't seem to cause downstream issues. Ok with you?
|
Also checked that these changes don't unexpectedly break epipredict (at least locally). |
dajmcdon
deleted the
208-epix_slide-converts-to-a-tibble-rather-than-an-epi_df-incompatible-with-arx_forecaster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve Issue #208 removed the two
as_tibble()calls in archive slide function so thatepix_slide()is compatible witharx_forecaster()from epipredict (to be able to slide an ARX forecaster over an archive). Making a separate issue to deal with the metadata.