Skip to content

epi_archive$as_of still converts to tibble #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dajmcdon opened this issue Sep 12, 2022 · 2 comments
Closed

epi_archive$as_of still converts to tibble #225

dajmcdon opened this issue Sep 12, 2022 · 2 comments
Labels
bug Something isn't working P1 medium priority

Comments

@dajmcdon
Copy link
Contributor

We removed this conversion in epi_archive$slide in #212. Should we also remove here?
@dajmcdon dajmcdon added question Further information is requested P1 medium priority labels Sep 12, 2022
@brookslogan
Copy link
Contributor

Yes, for consistency with other epi_df operations, I think as_of should

  • if the result looks like it could be a valid epi_df, output an epi_df
  • otherwise, output a tibble

and as far as I know, as_of should always be in the former situation. Do you have an example where it doesn't output an epi_df? I would have thought it would already produce only epi_dfs due to this line.

@brookslogan brookslogan added bug Something isn't working and removed question Further information is requested labels Sep 12, 2022
@dajmcdon
Copy link
Contributor Author

Ah, of course. Should have read more carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P1 medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dajmcdon @brookslogan