compactify changes including adding a vignette
#118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into epi_slide-error_message # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge branch 'main' into epi_slide-error_message
Merge branch 'main' into epi_slide-error_message
…tatement Merge branch 'main' into epi-archive-print
…. Also, improved warning message
Merge branch 'main' of https://github.com/dajmcdon/epiprocess into km-compactify_time # Conflicts: # DESCRIPTION # R/archive.R # data-raw/archive_cases_dv.R
…ich includes performances with and without LOCF applied to data.
|
Closes #111. Note this comment if it is still applicable to this PR. |
kenmawer
added a commit
to dajmcdon/epiprocess
that referenced
this pull request
Jun 29, 2022
Merge branch 'km-compactify_time' into km-compactify_rectify # Conflicts: # DESCRIPTION # data-raw/archive_cases_dv.R
kenmawer
changed the title
compactify, as well as its indirect ability to save timecompactify changes including adding a vignette
|
Were all the changes that were in this PR incorporated into #101? |
|
I think that's right. @ken and I went through these together to decide which to keep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vignette describes
compactify, taken out from the archive vignette originally. It also describes how the use ofcompactifycan save time for operations such asas_of. Note that the runtimes are not hard-coded, meaning that the time it takes may differ from one run of the code to another.Note that once complete, the
archivevignette should have a link tocompactifyin it so a user can find the information they need by clicking "See more" or something of the like.