-
Notifications
You must be signed in to change notification settings - Fork 10
km-kill-lags branched off frosting. #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kenmawer I'm not sure what the error is here, but this needs some debugging. |
@dajmcdon These errors seem to be coming from tests of functions such as those relating to frosting, none of which I worked on. Here's an example from |
Right, but those errors come from tests that use
|
…ined `step_epi_naomit()` here.
…nto km-kill-lags-good
…use inappropriate integers to throw an error.
…for lead/lag based on shift.
Added requested changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you can safely edit this branch locally and push to the same remote.
…n for a shift of 0 with lead vs. lag, unless I put a third if/else for the shift == 0 case.
…ahead" from when the function is called.
…nto km-kill-lags-good
…t it fails on GitHub.
…ld. Preferably, the printing statements should be separated by lag and ahead.
If you merge |
…nto km-kill-lags-good
As described earlier, splitting the |
@kenmawer I fixed up the printing to work the way we discussed in my office. Why don't you pull locally, run the examples, and see what you think. Have a look at how I did it just to make sure that it makes sense. Once it does, you can |
Closes issue #22.