Skip to content

axe the outdated musings directory, it still lives in various places,… #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2023
Merged

axe the outdated musings directory, it still lives in various places,… #236

merged 1 commit into from
Sep 14, 2023

Conversation

dajmcdon
Copy link
Contributor

… including the stored-musings branch

@dajmcdon dajmcdon requested a review from dsweber2 September 13, 2023 15:25
@dajmcdon
Copy link
Contributor Author

@dsweber2 rather than forcing a merge, can you just ensure that I'm not missing something? I think I removed only the offending directory.

dsweber2
dsweber2 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see removals in musings, so lgtm? We'll have to pull this into formatting if we merge it before that branch, but that's not exactly hard.

TIL you can put .gitignore is subdirectories.

@dajmcdon
Copy link
Contributor Author

Wait for #226 .

@dajmcdon dajmcdon merged commit 015b0ea into main Sep 14, 2023
@dajmcdon dajmcdon deleted the axe-musings branch September 14, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsweber2 dsweber2 dsweber2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dajmcdon @dsweber2