-
Notifications
You must be signed in to change notification settings - Fork 10
Formatting #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting #226
Conversation
The last error is just because the styler doesn't have permissions to actually make a commit. The previous one was because of the same error as my other pull request, but this is now strictly based on that one |
Just to be clear, this PR seems to do 3 things:
Is that right? |
Yes, that's a good summary. |
@dsweber2 can you handle the conflicts above, or should I? |
Got it; best handled via local rebase; I also added the revised commit to The tests are broken on main btw. I think I reproduced exactly the same errors, but its hard to tell. |
If you merge |
7e28d27
to
77cd78b
Compare
alright, tests pass! And the new code on main is formatted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Merge when ready.
This just applies
style_pkg()
to the whole package. There's also a github action to automatically format any push; I'm less certain that will 100% work, because testing github actions is kind of a mess.