-
Notifications
You must be signed in to change notification settings - Fork 5
Address a few bugs #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The function you wanted was probably |
* Revert back to old `format_list` logic, which was simpler * Fix `format_item` to not insert extra spaces after some commas, which resulted in incorrect API requests. * Use `vapply` rather than `sapply` in `format_list` to potentially catch weird cases and express expectations. * Add a few formatting tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though hope we don't depend on int zips/fips somewhere already. Committed the approach I described above. Do you remember what request revealed the fip_code
typo? Wonder if we're missing some tests.
Thanks Logan! I don't recall what revealed the fip_code typo. To say that we're missing tests is an understatement: those two functions Just going to merge and leave making unit tests to another PR. |
Closes #69.
Closes #66.
Closes #65.
Closes #67.
On the last issue: request params get formatted differently depending on whether a vector or a list is handed as an argument. This is an attempt to make the outcome uniform. The issue is
So I added some logic to check for vectors and use
as.list
instead. The problem is that theis.vector
also yields TRUE for lists, so it's currently messing up the list-type handling. Would appreciate help/commits there.