Skip to content

Typo: fip_code; also, make sure it requires text rather than an integer #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brookslogan opened this issue Mar 15, 2023 · 1 comment · Fixed by #74
Closed

Typo: fip_code; also, make sure it requires text rather than an integer #65

brookslogan opened this issue Mar 15, 2023 · 1 comment · Fixed by #74
Labels
bug Something isn't working P0 Top priority

Comments

@brookslogan
Copy link
Contributor

fip_code should be fips_code here.

Additionally, this should require a string rather than an integer / strings rather than integers. (FIPS codes should include appropriate zero padding, so they should be strings.)
@brookslogan brookslogan added bug Something isn't working P0 Top priority labels Mar 15, 2023
@dshemetov
Copy link
Contributor

Part of #69

@dshemetov dshemetov mentioned this issue Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P0 Top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address a few bugs cmu-delphi/epidatr
2 participants
@dshemetov @brookslogan