refactor(endpoints): remove API arg exclusivity validation #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can/should this wait until we get the server-side checks in cmu-delphi/delphi-epidata#1159? Not sure if there's some GitHub magic to auto-merge or auto-undraft when an issue in another repo is closed. |
|
It would be convenient to merge now for us, just to get it off our plate, but it does remove a few guard rails for the users. I would guess that these wouldn't be very common errors, so it's not a big deal, but I don't have data on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in cmu-delphi/delphi-epidata#1159, if we commit to doing the exclusivity checks in the server, then with our changes in #99, we will forward API validation errors to the user here, so no need to duplicate the work in the client.
Closes #92 (via changed design direction).