-
Notifications
You must be signed in to change notification settings - Fork 5
Update issues&lags exclusivity checks to also consider as_of
#92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We probably don't need to do this in the client, since we can forward an informative error from the server once it's implemented. |
Update: looks like the server doesn't do validation either, so we should add some guardrails after all cmu-delphi/delphi-epidata#1159 |
Doing checks (a) [server-side and forwarding error in client] or (b) both client-side and server-side both make sense. Currently we have bad checks both client-side and server-side, so both would need updated for either of the above two approaches. |
Update: from the discussion in the linked thread above, I'm now leaning away from doing these validation checks and actually removing the existing issue/lag checks. |
I believe
covidcast
no longer supportsas_of
together withissues
orlags
. Other endpoints might still support. We should update the client-side checks. I believe it's also in an Issue somewhere to detect this on the server side as well.The text was updated successfully, but these errors were encountered: