Skip to content

Update issues&lags exclusivity checks to also consider as_of #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Apr 28, 2023 · 4 comments · Fixed by #146
Closed

Update issues&lags exclusivity checks to also consider as_of #92

brookslogan opened this issue Apr 28, 2023 · 4 comments · Fixed by #146
Labels
enhancement New feature or request P1 medium priority

Comments

@brookslogan
Copy link
Contributor

I believe covidcast no longer supports as_of together with issues or lags. Other endpoints might still support. We should update the client-side checks. I believe it's also in an Issue somewhere to detect this on the server side as well.

@dshemetov
Copy link
Contributor

dshemetov commented Apr 29, 2023

We probably don't need to do this in the client, since we can forward an informative error from the server once it's implemented.

@dshemetov dshemetov added enhancement New feature or request P1 medium priority labels May 3, 2023
@dshemetov
Copy link
Contributor

dshemetov commented May 3, 2023

Update: looks like the server doesn't do validation either, so we should add some guardrails after all cmu-delphi/delphi-epidata#1159

@brookslogan
Copy link
Contributor Author

brookslogan commented May 3, 2023

Doing checks (a) [server-side and forwarding error in client] or (b) both client-side and server-side both make sense. Currently we have bad checks both client-side and server-side, so both would need updated for either of the above two approaches.

@dshemetov
Copy link
Contributor

dshemetov commented May 4, 2023

Update: from the discussion in the linked thread above, I'm now leaning away from doing these validation checks and actually removing the existing issue/lag checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 medium priority
Projects
None yet
2 participants