Compress CSV responses from the API #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#210 added format=csv, but these responses are not currently compressed like JSON responses are. I'd like to switch to CSV format in the R client, so compression is important to add here.
korlaxxalrok
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Looks good, @capnrefsmmat. This seems like a straightforward change.
Additionally, sorry for the MEGA LATE review.
|
No problem. Safe to merge for auto-deploy? |
|
@capnrefsmmat Yeah, lets merge it today, but maybe be on the lookout for any breakage :) |
|
Confirmed that delphi.cmu.edu and api.covidcast.cmu.edu are now serving compressed responses. On one day of JHU confirmed_incidence_num:
So gzip is great, but for clients that understand CSV natively, the CSV format will be great for having much less to parse. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#210 added format=csv, but these responses are not currently compressed like JSON responses are.
I'd like to switch to CSV format in the R client, so compression is important to add here.