csv and raw json #210
Merged
csv and raw json #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass, tests look reasonable, code looks good. Needs a documentation update to match. I'm looping in some folks to decide whether we want to do a provisional merge now and fill in documentation later. |
|
Merging now; we'll tell some of our users about it as a beta and then add it to the public documentation in a future release. |
4 tasks
capnrefsmmat
added a commit
that referenced
this pull request
Nov 11, 2020
#210 added format=csv, but these responses are not currently compressed like JSON responses are. I'd like to switch to CSV format in the R client, so compression is important to add here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for
format=csvandformat=json. The former creates a CSV file the later a raw JSON array.To support the different messages, http status codes (500, 401, 400) are used which will in an error case also send the json object back