Make DataSignal construction more flexible #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
melange396
added a commit
that referenced
this pull request
Jul 25, 2024
...as was done for DataSignal() in #1303 , and using the same ugly over-extended comprehension pattern
melange396
added a commit
that referenced
this pull request
Jul 29, 2024
* chore: update docs * restrict DataSource() construction to only applicable fields ...as was done for DataSignal() in #1303 , and using the same ugly over-extended comprehension pattern --------- Co-authored-by: melange396 <[email protected]> Co-authored-by: george haff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass only reflexively valid fields to the
DataSignalconstructor when loading fromdb_signals.csv, instead of using a rigid and brittle set of fields (columns) to exclude. The system will now easily ignore new columns added to the CSV file, but for which it doesn't yet have a use. This will make it effortlessly handle changes coming in #1259 (and beyond).I considered logging a list of unused fields/columns, but that will already be noisy because of the existing
base_is_othercolumn, and i dont think itll be very helpful.