Skip to content

Update Google Docs Meta Data #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Update Google Docs Meta Data #1259

merged 5 commits into from
Oct 11, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Updating Google Docs Meta Data

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@melange396
Copy link
Collaborator

i ran the github action that produced this mostly as an experiment to see what it might generate... (prior runs of the action had their logs stripped due to age). i now believe that the tasks.py file is evaluated for this, though the workflow file makes no mention of it (we should fix that).

looks like recent updates to the external document include a few new columns added in the middle of the others: Source,"Pathogen/ Disease Area",Signal Type,Available Geography. the newly added "Source" column may break some things because an existing method already renames the "Source Subdivision" column to "source" during processing of db_signals.csv.

@carlynvandyke , looks like you made many of the recent edits to the source google spreadsheet document -- do we need to incorporate any of these changes into this repository?

@melange396
Copy link
Collaborator

I did some digging and the summary of changes for this PR looks to be:

  • Four new columns added: "Source", "Pathogen/\nDisease Area", "Signal Type", "Available Geography".
    • "Source" will probably need to be renamed, perhaps to "Source Description"?
  • Some variable substitutions happened, where bracketed strings in some columns appear to have been replaced with the text from other columns that they referenced.
    • The replacements happened for "{base_name}" in the "Name" column, and "{base_description}", "{short_desc}", or "{short_description}" in the "Description" column.
    • There are still some instances (9) of "variables" left in there, namely "{source_description}" and "{base_short_description}"
  • set "Active" column to "FALSE" on all 12 "usa-facts" signals.


""People fully vaccinated includes those who have received two doses of the Pfizer-BioNTech or Moderna vaccine and those who have received one dose of the J&J/Janssen vaccine"" - from the CPR data dictionary.",day,Day,Value,count,public,good,FALSE,FALSE,TRUE,FALSE,FALSE,https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/dsew-cpr.html
fb-survey,raw_wcli,FALSE,raw_wcli,FALSE,COVID-Like Symptoms,TRUE,Estimated percentage of people with COVID-like illness ,"{source_description} For this signal, we estimate the percentage of people self-reporting COVID-like symptoms, defined here as fever along with either cough, shortness of breath, or difficulty breathing. While many other conditions can cause these symptoms, comparing the rates of COVID-like symptoms across the country can suggest where COVID is most active.",day,Date,Percentage,percent,early,bad,FALSE,TRUE,FALSE,TRUE,TRUE,"[Survey details](https://delphi.cmu.edu/covidcast/surveys/)
Source Subdivision,Signal BaseName,base_is_other,Signal,Compute From Base,Name,Active,Short Description,Description,Source Description,"Pathogen/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Source Subdivision,Signal BaseName,base_is_other,Signal,Compute From Base,Name,Active,Short Description,Description,Source Description,"Pathogen/
Source Subdivision,Signal BaseName,base_is_other,Signal,Compute From Base,Name,Active,Short Description,Description,Source Name,"Pathogen/

(better column name choice, after discussing w/ @carlynvandyke)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@melange396
Copy link
Collaborator

final summary TL;DR:

  • 4 new columns
  • new "Source" column manually renamed to "Source Name"
  • some (but not all) templated variables resolved/dereferenced
  • "usa-facts" marked inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant