Skip to content

Make Epidata.sensors.auth optional #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

Make Epidata.sensors.auth optional #1075

merged 1 commit into from
Mar 3, 2023

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Feb 2, 2023 •
edited
Loading

Fixes #49

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Removes auth from argument requirements, and adds it to the request params only if specified.

@krivard
Make Epidata.sensors.auth optional
45c7827 
Removes `auth` from argument requirements, and adds it to the request params only if specified. Fixes #49
@krivard krivard requested a review from rzats February 23, 2023 20:51
@krivard krivard merged commit 8a48c4f into dev Mar 3, 2023
@krivard krivard deleted the krivard/epidata-sensors-auth branch March 3, 2023 14:55
@krivard krivard mentioned this pull request Mar 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzats rzats rzats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clients incorrectly requiring auth parameter for sensors source
2 participants
@krivard @rzats