Skip to content

clients incorrectly requiring auth parameter for sensors source #49

Closed
@pedritom-amzn

Description

@pedritom-amzn

problem: the auth parameter is optional for the sensors api:

if(require_all($data, array('names', 'locations', 'epiweeks'))) {
if(!array_key_exists('auth', $_REQUEST)) {
$auth_tokens_presented = array();
} else {
$auth_tokens_presented = extract_values($_REQUEST['auth'], 'str');
}

however, the clients are all incorrectly requiring the auth parameter to access sensors, e.g.:

def sensors(auth, names, locations, epiweeks):
"""Fetch Delphi's digital surveillance sensors."""
# Check parameters
if auth is None or names is None or locations is None or epiweeks is None:
raise Exception('`auth`, `names`, `locations`, and `epiweeks` are all required')

impact: customers of the clients will be incorrectly restricted from using the sensors source without auth.

proposal: make auth optional for sensors in the clients.

Metadata

Metadata

Assignees

No one assigned

    Labels

    EngineeringUsed to filter issues when synching with Asana

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions