Skip to content

update code for unassigned cases/deaths #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 19, 2020

Conversation

jingjtang
Copy link
Contributor

No description provided.

@krivard
Copy link
Contributor

krivard commented Jun 8, 2020

Recommend adding a test case or extending an existing test to include Unassigned counties, so we can check that the megacounty aggregations all work.

@jingjtang jingjtang closed this Jun 10, 2020
@jingjtang
Copy link
Contributor Author

Recommend adding a test case or extending an existing test to include Unassigned counties, so we can check that the megacounty aggregations all work.

Test cases are added. @krivard

@jingjtang jingjtang reopened this Jun 10, 2020
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit mega hrrs and msas at a later date; currently the API won't accept them as implemented here. I've suggested changes to revert. Otherwise good!

@krivard krivard merged commit 5931e21 into run-jhu Jun 19, 2020
@jingjtang jingjtang deleted the jingjing/jhu_with_unassigned branch June 25, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants