Skip to content

[DELETED] Update smoothed safegraph signal names #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[DELETED] Update smoothed safegraph signal names #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b96a1a
migrate safegraph.run back onto using functools.partial
sgsmob Oct 21, 2020
933c6b4
fix output file format from YYYY-MM-DD to YYYYMMDD
sgsmob Oct 21, 2020
117bc9f
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
sgsmob Oct 21, 2020
df63e15
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
sgsmob Oct 29, 2020
6559a39
Merge branch 'main' of github.com:cmu-delphi/covidcast-indicators int…
sgsmob Nov 18, 2020
3cb534c
update safegraph signal names to use correct suffixes
sgsmob Nov 18, 2020
279ed47
adding back in deleted comment
sgsmob Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion safegraph/delphi_safegraph/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def process(filenames: List[str],
export_dir)
# ...then as part of the whole window.
process_window(past_week,
add_prefix(add_suffix(signal_names, '_7d_avg'),
add_prefix(add_suffix(signal_names, '_7dav'),
wip_signal,
'wip_'),
geo_resolutions,
Expand Down
8 changes: 4 additions & 4 deletions safegraph/params.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"aws_default_region": "",
"aws_endpoint": "",
"sync": true,
"wip_signal" : ["median_home_dwell_time_7d_avg",
"completely_home_prop_7d_avg",
"part_time_work_prop_7d_avg",
"full_time_work_prop_7d_avg"]
"wip_signal" : ["median_home_dwell_time_7dav",
"completely_home_prop_7dav",
"part_time_work_prop_7dav",
"full_time_work_prop_7dav"]
}
8 changes: 4 additions & 4 deletions safegraph/tests/params.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"aws_secret_access_key": "",
"aws_default_region": "",
"aws_endpoint": "",
"wip_signal" : ["median_home_dwell_time_7d_avg",
"completely_home_prop_7d_avg",
"part_time_work_prop_7d_avg",
"full_time_work_prop_7d_avg"],
"wip_signal" : ["median_home_dwell_time_7dav",
"completely_home_prop_7dav",
"part_time_work_prop_7dav",
"full_time_work_prop_7dav"],
"sync": false
}
10 changes: 5 additions & 5 deletions safegraph/tests/test_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def test_process(self, tmp_path):
'raw_data/small_raw_data_3.csv'],
SIGNALS,
['median_home_dwell_time',
'completely_home_prop_7d_avg'],
'completely_home_prop_7dav'],
['state'],
export_dir)

Expand Down Expand Up @@ -157,25 +157,25 @@ def test_process(self, tmp_path):
'se': [None, 0.005],
'sample_size': [1, 2]
}),
'median_home_dwell_time_7d_avg': pd.DataFrame(data={
'median_home_dwell_time_7dav': pd.DataFrame(data={
'geo_id': ['al', 'ga', 'pa'],
'val': [4.5, 3.5, 7.5],
'se': [1.5, 0.5, 0.5],
'sample_size': [2, 2, 2]
}),
'wip_completely_home_prop_7d_avg': pd.DataFrame(data={
'wip_completely_home_prop_7dav': pd.DataFrame(data={
'geo_id': ['al', 'ga', 'pa'],
'val': [0.1, 0.055, 0.15],
'se': [0.05, 0.005, 0.05],
'sample_size': [2, 2, 2]
}),
'part_time_work_prop_7d_avg': pd.DataFrame(data={
'part_time_work_prop_7dav': pd.DataFrame(data={
'geo_id': ['al', 'ga', 'pa'],
'val': [0.25, 0.055, 0.25],
'se': [0.1, 0.005, 0.05],
'sample_size': [2, 2, 2]
}),
'full_time_work_prop_7d_avg': pd.DataFrame(data={
'full_time_work_prop_7dav': pd.DataFrame(data={
'geo_id': ['al', 'ga', 'pa'],
'val': [0.35, 0.055, 0.35],
'se': [0.1, 0.005, 0.05],
Expand Down
2 changes: 1 addition & 1 deletion safegraph/tests/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def test_output_files_exist(self, run_as_module):
single_date_signal = "_".join([date, geo, signal]) + ".csv"
expected_files.add(single_date_signal)
single_date_signal = "_".join(
[date, geo, "wip", signal, "7d_avg"]) + ".csv"
[date, geo, "wip", signal, "7dav"]) + ".csv"
expected_files.add(single_date_signal)

assert expected_files == csv_files
Expand Down