Skip to content

[DELETED] Update smoothed safegraph signal names #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

sgsmob
Copy link
Contributor

@sgsmob sgsmob commented Nov 18, 2020

Description

Update the work-in-progress safegraph signal names to conform to our naming conventions.

Changelog

  • Signals ending in 7d_avg now end in 7dav

Fixes

part of #332

@sgsmob sgsmob requested review from a team and huisaddison and removed request for a team November 18, 2020 22:18
@krivard
Copy link
Contributor

krivard commented Nov 19, 2020

it looks like you're reusing your old weekday branch, which contains commits that got rebased when we fixed the safegraph stuff a month ago. The commits from "29 days ago" looked suspicious, so I checked, and there's already a commit with message "migrate safegraph.run back onto using functools.partial" in main.

Recommend doing the following:

  1. make a new branch off main
  2. cherry pick 3cb534c and 279ed47
  3. delete outdated weekday branch
  4. either submit a new PR with the new branch and close this one, or rename the new branch to weekday and force-push to update this one

@sgsmob sgsmob changed the title Update smoothed safegraph signal names [DELETED] Update smoothed safegraph signal names Nov 19, 2020
@sgsmob sgsmob closed this Nov 19, 2020
@sgsmob
Copy link
Contributor Author

sgsmob commented Nov 19, 2020

it looks like you're reusing your old weekday branch, which contains commits that got rebased when we fixed the safegraph stuff a month ago. The commits from "29 days ago" looked suspicious, so I checked, and there's already a commit with message "migrate safegraph.run back onto using functools.partial" in main.

Recommend doing the following:

  1. make a new branch off main
  2. cherry pick 3cb534c and 279ed47
  3. delete outdated weekday branch
  4. either submit a new PR with the new branch and close this one, or rename the new branch to weekday and force-push to update this one

Done, see #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants