Remove dependency on cache files from GHT tests #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgsmob
suggested changes
Nov 6, 2020
sgsmob
suggested changes
Nov 7, 2020
google_health/tests/test_pull_api.py
Outdated
|
|
||
| def test_class_state(self): | ||
|
|
||
| # TODO |
There was a problem hiding this comment.
please add the Github issue here and to the other TODOs.
There was a problem hiding this comment.
Sorry I wasn't clearer on this. You should create a github issue called something like "Get the ght tests to work without authentication" and explain a bit more in the description. Then, in the commented out tests you should leave a comment that says "TODO(#XXX): reenable these tests" where XXX is the number of the issue you created.
sgsmob
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
The unit tests coverage is good for all of the scrips except for
pull_api.pysince a large proportion of the code in that script requires ght-key to pull data from the Google Health Trends API. Currently, didn't find a good way to test those functions.