Skip to content

Remove dependency on cache files from GHT tests #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krivard opened this issue Aug 12, 2020 · 1 comment · Fixed by #444 or #521
Closed

Remove dependency on cache files from GHT tests #213

krivard opened this issue Aug 12, 2020 · 1 comment · Fixed by #444 or #521
Assignees
@jingjtang
Labels
good first issue

Comments

@krivard
Copy link
Contributor

krivard commented Aug 12, 2020

As suggested by #211 -- unit tests should not depend on the live cache files. Tests that check caching behavior should use a static dataset stored in the tests directory.
@krivard krivard mentioned this issue Aug 25, 2020
Merged
@krivard krivard mentioned this issue Nov 2, 2020
Closed
@jingjtang jingjtang mentioned this issue Nov 4, 2020
Merged
@jingjtang jingjtang self-assigned this Nov 6, 2020
@jingjtang
Copy link
Contributor

PR here #444

@jingjtang jingjtang mentioned this issue Nov 6, 2020
Merged
@jingjtang jingjtang mentioned this issue Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jingjtang jingjtang

Labels
good first issue
Projects
None yet
Milestone
No milestone
2 participants
@krivard @jingjtang