Skip to content

Make combo cases/deaths robust to source outages #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2020
Merged

Make combo cases/deaths robust to source outages #343

merged 3 commits into from
Oct 22, 2020

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Oct 20, 2020

  • okay to return just one of the data frames if both aren't available
  • do something sensible if neither one is available
  • unit tests to verify all possible cases are handled appropriately

Fixes #330

@krivard
Make combo cases/deaths robust to source outages
9e46bc2 
- okay to return just one of the data frames if both aren't available
- do something sensible if neither one is available
- unit tests to verify all possible cases are handled appropriately

Fixes #330
@krivard krivard requested a review from nmdefries October 20, 2020 20:45
@chinandrew chinandrew mentioned this pull request Oct 21, 2020
Closed
@krivard krivard requested review from sgsmob and removed request for nmdefries October 21, 2020 19:27
sgsmob
sgsmob suggested changes Oct 22, 2020
View reviewed changes
@capnrefsmmat capnrefsmmat mentioned this pull request Oct 22, 2020
Closed
@krivard krivard requested a review from sgsmob October 22, 2020 14:38
sgsmob
sgsmob approved these changes Oct 22, 2020
View reviewed changes
@krivard krivard merged commit 2904c1d into main Oct 22, 2020
@krivard krivard deleted the fix/combo-robustify branch October 29, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat left review comments

@chinandrew chinandrew chinandrew left review comments

@sgsmob sgsmob sgsmob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make combo cases & deaths robust to outages
4 participants
@krivard @capnrefsmmat @sgsmob @chinandrew